Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.8.0: Filters, Room settings and more #189

Open
wants to merge 101 commits into
base: main
Choose a base branch
from
Open

3.8.0: Filters, Room settings and more #189

wants to merge 101 commits into from

Conversation

greeeen-dev
Copy link
Member

Checklist

  • My code follows the repository code of conduct.
  • I have tested this code to make sure it works as intended.

Details

Tests

Relevant issues

cogs/badge.py Outdated
Comment on lines 59 to 70
self.unifier_team_data = {}
self.check_unifier_team.start()

@tasks.loop(minutes=30)
async def check_unifier_team(self):
url = "https://colab.unifierhq.org/data.json"
async with aiohttp.ClientSession() as session:
async with session.get(url) as response:
if response.status == 200:
self.unifier_team_data = await response.json()
else:
self.logger.warning(f"Failed to fetch Unifier team data: {response.status}")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could just do this by having a json file on the repo (or another) tbh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is https://github.com/UnifierHQ/colaborators , but a GET requests is faster and more lightweight.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that explains the cname, but consider renaming that to "collaborators" since that's the correct spelling

same goes for the subdomain

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't want to make the url extremely long, specially for the gui.

@greeeen-dev greeeen-dev marked this pull request as ready for review February 3, 2025 20:59
@greeeen-dev
Copy link
Member Author

Marked this as ready for review (testing still required)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v3.x Applies to v3.x
Projects
None yet
3 participants