Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hologram table animation prematurely ends. #5

Open
clementshimizu opened this issue Aug 29, 2019 · 1 comment
Open

hologram table animation prematurely ends. #5

clementshimizu opened this issue Aug 29, 2019 · 1 comment

Comments

@clementshimizu
Copy link

Sometimes, but not always the hologram table animation galaxy state animation starts playing but then it closes before you have the opportunity to click on anything. The "FTL target system" loading bar is up and blinking. But the galaxy faded out to nothing.

I have been able to find is state machine attached to hologram table (if i make the state public) is at Galaxy and the animation on galaxy/GalaxyFadeIn is a few frames beyond the end of the animation if the bug occours, and at the blue line if the bug doesn't occur.
I am unsure if that is normal or not, but if i rewind the animation back to the blue line the galaxy comes back.

This is what it looks like when the bug does not happen:
image

This is what it looks like when the bug happens:
image

@clementshimizu
Copy link
Author

I think i found the bug in GameplayIngredients.Rig.DirectorControlRig->Update line 64
director.time = newTime
should be

if (m_PlayMode == PlayMode.Reverse) {
director.time = newTime < 0 ? 0 : newTime;
} else {
director.time = newTime > director.playableAsset.duration ? director.playableAsset.duration : newTime;

this change prevents the timeline from being played outside of the playable region if for example the time step is greater than one fps. Not sure if this is the correct fix because the code needs to be changed in the package manager library.....

peeweek pushed a commit that referenced this issue Feb 12, 2020
* Updated Console Package

* Updated API for Console Commands
peeweek added a commit that referenced this issue Aug 6, 2020
* Benchmark Base Work

* Added Part 2 to the Benchmark Walkthrough

* Small Fixes (Disabled Verbose, better handling of full screen fade in wrecked)

* Final Fixes

* Delete Old PlayerStart

* Saved Benchmark Items as Prefabs

* Fixed Walkthrough for Benchmark

* Added Ending Benchmark Script for iOS / Fix of issue #5 (hologram table animation prematurely ends) in DirectorControlRig

* Fixes from @aet

* Removed SceneIDMap game objects

* Quality Fixes on Benchmark

Co-authored-by: Thomas ICHÉ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant