Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display confirmation dialog before swap is started #61

Open
binarybaron opened this issue Sep 2, 2024 · 1 comment
Open

Display confirmation dialog before swap is started #61

binarybaron opened this issue Sep 2, 2024 · 1 comment
Labels
GUI Related to the Tauri GUI Tauri <> GUI Connector Requires new communication between Tauri and the GUI

Comments

@binarybaron
Copy link

We should display a dialog to allow the user to accept a swap before it is started.

This is especially important if the user still has funds in the internal wallet, the swap will currently be started instantaneously. This is not a good experience.
@binarybaron binarybaron added GUI Related to the Tauri GUI Tauri <> GUI Connector Requires new communication between Tauri and the GUI labels Sep 2, 2024
@binarybaron
Copy link
Author

We should merge comit-network#1662 before implementing this. It'll allow us to display a countdown until the swap has to be accepted inside the GUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GUI Related to the Tauri GUI Tauri <> GUI Connector Requires new communication between Tauri and the GUI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binarybaron