Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What status should a dataset be in when an uninstall fails? #222

Open
Foxcapades opened this issue Feb 6, 2024 · 3 comments
Open

What status should a dataset be in when an uninstall fails? #222

Foxcapades opened this issue Feb 6, 2024 · 3 comments
Labels
investigation Further information is requested

Comments

@Foxcapades
Copy link
Member

Foxcapades commented Feb 6, 2024

There are no statuses tracking dataset uninstall status. We have no indication for uninstallation failures.

Datasets that are marked as deleted are hidden from the UI so this would not impact UX and would be for internal use only.

@steve-fischer-200
Copy link
Contributor

steve-fischer-200 commented Apr 23, 2024

The only place this would be known is by looking at the logs.

We might want something in pg, or use the install-status

@Foxcapades
Copy link
Member Author

I propose an overhaul of the current InstallStatus enum to track the full lifecycle of datasets in an application database.

If I had my way, I would change InstallStatus to AppDbDatasetStatus and make the following changes to the values:

  • Rename:

    • running -> install-running
    • complete -> install-complete
  • Add:

    • uninstall-running
    • uninstall-complete
    • uninstall-failed
    • ready-for-uninstall

Additionally I would change the is_deleted flag field in the datasets control table back to a boolean value rather than a 3-state int enum and rely on using the ready-for-uninstall status rather than an int value whose meaning will be lost to time.

@Foxcapades
Copy link
Member Author

The only place this would be known is by looking at the logs.

We might want something in pg, or use the install-status

This would also be visible in the app db

@Foxcapades Foxcapades added investigation Further information is requested and removed enhancement labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigation Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants