Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS support? #33

Open
deanylev opened this issue Oct 8, 2024 · 2 comments
Open

tvOS support? #33

deanylev opened this issue Oct 8, 2024 · 2 comments

Comments

@deanylev
Copy link

deanylev commented Oct 8, 2024

Now that the WebRTC SDK has tvOS support webrtc-sdk/webrtc#139

How hard would it be to adapt this lib to work on tvOS?

@fedulvtubudul
Copy link
Collaborator

"This lib" is just a wrapper and a build script, it does not have anything platform-specific, so I don't think it should be too hard. On the other hand you point to a non-official WebRTC repo, while we use Google WebRTC with some iOS-specific patches.

You can try swapping WebRTC repo in the build script and add a new build target. I don't mind adding tvOS support if you make a PR. But as our app is only for iOS, I can't invest time into something we don't use and can't even test.

@deanylev
Copy link
Author

Haha, I always forget that repo is not the official WebRTC SDK 🤦

I thought as much though, I will have a crack at it. I can't think of a good way to raise a generalised PR if the build script uses the official WebRTC SDK though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants