Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide update.json for module updates within magisk app #13

Open
ClockGen opened this issue Feb 6, 2024 · 1 comment
Open

Provide update.json for module updates within magisk app #13

ClockGen opened this issue Feb 6, 2024 · 1 comment

Comments

@ClockGen
Copy link

ClockGen commented Feb 6, 2024

Hello, magisk supports module updates from within the app itself, if the module has proper fields in module.prop and appropriate update.json file upstream (see https://topjohnwu.github.io/Magisk/guides.html). Could you provide these?

@IzzySoft
Copy link

IzzySoft commented Feb 6, 2024

Guess you can mark this "solved", @ClockGen: the update.json is named module.json here (so at least my Magisk repo can handle that), and the proper fields in module.prop seem to be present.

Issue still remains: the ZIP contains an invalid module.prop:

author=VR25
description=
domain=vr25
id=zram-swap-manager
name=zRAM Swap Manager
version=
versionCode=

Values for description, version and versionCode are missing, resulting in an

Pull ERROR: _from_zip_common: [zram-swap-manager] -> ValueError(invalid literal for int() with base 10: '')

when versionCode is being evaluated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants