Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read ReaderCloser #49

Closed
nicola-spb opened this issue Nov 20, 2022 · 2 comments · Fixed by #50
Closed

Add read ReaderCloser #49

nicola-spb opened this issue Nov 20, 2022 · 2 comments · Fixed by #50
Assignees
@Valentin-Kaiser
Labels
enhancement New feature or request

Comments

@nicola-spb
Copy link

Please add in OpenTable function reading from io.ReadCloser interface.
I have files in archive and func return io.ReaderCloser. I think it will be useful.
@Valentin-Kaiser
Copy link
Owner

Hello @nicola-spb,
Thanks for your request, that sounds like a useful extension, I'll have a look at it. And provide feedback on feasibility and duration.

Kind regards,
Valentin-Kaiser

@Valentin-Kaiser Valentin-Kaiser self-assigned this Nov 21, 2022
@Valentin-Kaiser Valentin-Kaiser added the enhancement New feature or request label Nov 21, 2022
@Valentin-Kaiser Valentin-Kaiser mentioned this issue Nov 22, 2022
Merged
@Valentin-Kaiser Valentin-Kaiser linked a pull request Nov 22, 2022 that will close this issue
Implemented io.ReadWriteSeeker and made IO operations customizable #50
Merged
@Valentin-Kaiser
Copy link
Owner

Valentin-Kaiser commented Nov 22, 2022 •
edited
Loading

Hello @nicola-spb,
could you test the whole thing with the v1.9.1?
You can now pass a GenericIO Struct as a second parameter to the OpenTable function. This struct has two attributes, one for the DBF and one for the related FPT file if available.
Please give me feedback if it works and if you encounter any errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Valentin-Kaiser Valentin-Kaiser

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented io.ReadWriteSeeker and made IO operations customizable Valentin-Kaiser/go-dbase
2 participants
@nicola-spb @Valentin-Kaiser