Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable LAA by default #3477

Closed
2 tasks done
soredake opened this issue Jan 29, 2020 · 9 comments
Closed
2 tasks done

enable LAA by default #3477

soredake opened this issue Jan 29, 2020 · 9 comments
Labels
Feature Request New feature or request
Milestone

Comments

@soredake
Copy link
Contributor

soredake commented Jan 29, 2020

Feature Request

I confirm:

  • that I haven't found another request for this feature.
  • that I have checked whether there are updates for my system available that
    contain this feature already.

Description

Enable LAA by default and disable for problem ones.

Justification [optional]

Many games will benefit from this.

Risks [optional]

Some games might crash https://github.com/Tk-Glitch/PKGBUILDS/issues/401, but we can disable laa for them.

References [optional]

TKG did this
Tk-Glitch/PKGBUILDS@b0fe54e
Tk-Glitch/PKGBUILDS@5a69474

@kisak-valve kisak-valve added the Feature Request New feature or request label Jan 29, 2020
@mirh
Copy link

mirh commented Feb 8, 2020

I don't know, this seems more like a hack to workaround the bigger problem of mysteriously higher memory usage (#177 doitsujin/dxvk#1318) than anything

@Tk-Glitch
Copy link

It most definitely is. But can this actually be fully fixed? I would assume DXVK's memory overhead reduction has its limits.

@mirh
Copy link

mirh commented Feb 9, 2020

I mean, just this month nvidia finally fixed a big bug with that. So.. we are progressing?
It doesn't help that the number of users actually reasoning with the memory map numbers under the eyes is pretty low.

@CSahajdacny
Copy link

Well.. Borderlands: The Pre-sequel running via forced Proton still crash complaining about memory allocation error if UHD textures pack is installed, with D9VK/DXVK enabled.... With PROTON_USE_WINED3D enabled it doesn't crash, but the performance sucks!

@vinifmor
Copy link

@CSahajdacny, if you are running over a Nvidia GPU, try to disable the game vsync. It's not a rule, but one of my games was raising DxvkMemoryAllocationError because of its own vsync implementation. The sync is still done even when the setting is turned off. It makes me believe somehow for this specific game the vsync was done twice and the memory crashed.

@CSahajdacny
Copy link

@CSahajdacny, if you are running over a Nvidia GPU, try to disable the game vsync. It's not a rule, but one of my games was raising DxvkMemoryAllocationError because of its own vsync implementation. The sync is still done even when the setting is turned off. It makes me believe somehow for this specific game the vsync was done twice and the memory crashed.

Thanks for the tip. I'm gonna try and report the result.

@aeikum aeikum added this to the Next Release milestone Mar 4, 2020
@soredake
Copy link
Contributor Author

image

@aeikum
Copy link
Collaborator

aeikum commented Mar 11, 2020

As you noted, the Large Address Aware flag is enabled by default beginning with Proton 5.0-4. If you find this causing issues with certain games, please let us know in the game's issue page.

You can disable forcing the LAA flag by setting PROTON_FORCE_LARGE_ADDRESS_AWARE=0.

@aeikum aeikum closed this as completed Mar 11, 2020
@shoober420
Copy link

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants