Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map out data notifications in the rust api #6293

Open
greaka opened this issue Jan 1, 2025 · 0 comments
Open

Map out data notifications in the rust api #6293

greaka opened this issue Jan 1, 2025 · 0 comments
Assignees
Labels
Component: Rust API Issue needs changes to the Rust API Effort: Trivial Issue should take < 1 day Impact: Medium Issue is impactful with a bad, or no, workaround
Milestone

Comments

@greaka
Copy link

greaka commented Jan 1, 2025

What is the feature you'd like to have?
BNBinaryDataNotification would allow me to subscribe to data events emitted by BVs.

Is your feature request related to a problem?
I would like to write plugins using that api.

Are any alternative solutions acceptable?
Lot's of ideas on how to implement it, but the quick and easy one is probably preferable at this time.

Additional Information:
A quick and easy solution would be to expose the notifier as a trait and on callback init/register check for fn ptr equality for impls compared to a dummy struct to only subscribe to what's implemented.

@emesare emesare self-assigned this Jan 1, 2025
@emesare emesare added Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround Effort: Trivial Issue should take < 1 day Component: Rust API Issue needs changes to the Rust API labels Jan 1, 2025
@emesare emesare added this to the Gallifrey milestone Jan 1, 2025
@emesare emesare removed the Effort: Low Issue should take < 1 week label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Rust API Issue needs changes to the Rust API Effort: Trivial Issue should take < 1 day Impact: Medium Issue is impactful with a bad, or no, workaround
Projects
None yet
Development

No branches or pull requests

2 participants