Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchrounous API does not validate the status of the target #676

Open
xusheng6 opened this issue Dec 17, 2024 · 0 comments
Open

Synchrounous API does not validate the status of the target #676

xusheng6 opened this issue Dec 17, 2024 · 0 comments
Assignees
Milestone

Comments

@xusheng6
Copy link
Member

In DebuggerController::Go,

bool DebuggerController::Go()
{
// This is an API function of the debugger. We only do these checks at the API level.
if (!CanResumeTarget())
return false;
std::thread([&]() { GoAndWait(); }).detach();
return true;
}
, we check CanResumeTarget before issuing the commands. However, this is not done for all the synchrounous APIs, e.g., GoAndWait

This partially contributes to #672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant