Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippets should not be loaded in headless mode #31

Open
xusheng6 opened this issue May 8, 2022 · 1 comment
Open

snippets should not be loaded in headless mode #31

xusheng6 opened this issue May 8, 2022 · 1 comment

Comments

@xusheng6
Copy link
Member

xusheng6 commented May 8, 2022

Currently, I observe that the snippets plugin is also loaded in headless mode. I observed this when I try to run the BN unit tests. While this is related to Vector35/binaryninja-api#1556, but it is different. Python plugins are too flexible and BN have no way of differentiating core/UI plugins, so the plugin itself should detect whether it is running in headless mode and decide whether it should load. binaryninja.core_ui_enabled() should fit the purpose.

@psifertex
Copy link
Member

Snippets can be triggered via the action system so maybe having them load in headless is worth keeping? Not sure. I'm not against disabling it though.

That said, unit tests should always be run with BN_DISABLE_ PLUGINS set anyway fwiw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants