Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File creation #8

Open
Alystrasz opened this issue Sep 12, 2022 · 0 comments
Open

File creation #8

Alystrasz opened this issue Sep 12, 2022 · 0 comments

Comments

@Alystrasz
Copy link
Member

Currently, on the receiving end, file creation is done in a synchronous fashion: all file chunks are stored in memory upon reception, and exported to file in order. This prevents transfering files bigger than receiver device's memory size, and does not allow failure recovery in case file exchange goes wrong.

  1. Receiver end should acknowledge file chunks only after they have been stored somewhere safe.
  2. Moreover, instead of saving all chunks in memory, we should write them directly in destination file at correct position (use a RandomAccessFile instance to allow this).
@Alystrasz Alystrasz mentioned this issue Sep 14, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant