rubocop Lint/MissingSuper for generated initialize method

[klyonrad]

I generated a view component.

When I run rubocop I see the following warning

W: Lint/MissingSuper: Call super to initialize state of the parent class.

Since this rubocop is in the Lint space I don't feel 100% confident of just disabling it because it is in my way

Who or what is doing something wrong?

• the view component gem?
• rubocop
  • The cop is a bit controversial apparently
    • ~~Consider disabling~~ Re-enable Lint/MissingSuper standardrb/standard#195 (comment)
    • Lint/MissingSuper false positive rubocop/rubocop#8506
• Me?

[Spone]

Hi @klyonrad! Can you show us the component? (At least the class declaration and the initialize method)

Thanks!

[Spone]

I guess you can either:

• add super as suggested by the cop
• add an exception to rubocop config, for this specific cop, for the app/components folder.

[boardfish]

It seems as though there's not a configuration option for Lint/MissingSuper to ignore our classes, so @Spone is right to suggest you add this to your .rubocop.yml:

Lint/MissingSuper:
  Exclude:
    - 'app/components/**/*'

[klyonrad]

@Spone @boardfish I am sorry but that was not my question. I know (and I think many others) how to configure rubocop and adjust to my needs. But this is not a style cop, but a Lint cop that usually guards against many insecure coding styles.

I don't feel 100% confident of just disabling it

I am asking for What is the correct (and idiomatic) ruby.

But I guess you answered the question implicitly, right? Rubocop is wrong. So that means we should advocate in the rubocop project of disabling this guard

[Spone]

I think the right answer is it depends 😬

If your components inherit from ViewComponent::Base you don't need to call super in initialize.

If you inherit from ApplicationComponent you may have defined code in your initialize method, so if you want this code to run for each component you need to call super.

I think rubocop cannot figure this out for you, so you have to pick what's best in your case.

[klyonrad]

I think rubocop cannot figure this out for you, so you have to pick what's best in your case.

Which in my opinion makes this cop not super helpful

Anyway, thanks for your insight and patience! :)