-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing for the next minor Ruby version #2033
Comments
@boardfish in #2030 I also noticed a tests that was failing because of mismatched regex/string encodings I wonder if this is a bug in ruby(no mention in https://bugs.ruby-lang.org/) or a breaking change, just thought its worth noting |
Interesting! Good to see that testing against Ruby |
@boardfish I am seeing a lot of these warnings, what strategy do you think we should use to collect and diagnose which dependencies they are coming from |
@boardfish I have been thinking about this, since the release is so nearby this is quite important now, maybe we could do a test run, with some kind of mechanism to catch any warnings against ruby main, then report any issues to our dependencies |
@Spone ruby 3.4 has launched and with it I have tested locally for any warnings related to the chilled strings and have got none, would you mind verifying if this is the case for you too |
It seems as though the next Ruby version will default to string literals being frozen. The linked gist outlines some things we can add to CI to make sure we're not falling foul of this.
Depending on whether there are any violations or not, we could enforce it strictly or add it as a test matrix option that we don't require in order for CI to pass. Happy to pick this up myself in the near future.
The text was updated successfully, but these errors were encountered: