Skip to content
This repository has been archived by the owner on Dec 13, 2024. It is now read-only.

Add juice command #81

Closed
wants to merge 8 commits into from
Closed

Conversation

PlaceReporter99
Copy link
Contributor

Buy, sell, and browse the catalog of juices!

Fixes issue Vyxal/VyxalBot3#3.

Buy, sell, and browse the catalog of juices!
Copy link
Contributor

@nayakrujul nayakrujul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think we should wait for @GingerIndustries's review before merging

@nayakrujul nayakrujul requested a review from gingershaped June 12, 2023 15:20
@PlaceReporter99
Copy link
Contributor Author

PlaceReporter99 commented Jun 12, 2023

LGTM but I think we should wait for @GingerIndustries's review before merging

Yes they are the co-owner.

@PlaceReporter99
Copy link
Contributor Author

@nayakrujul would i also need to add to the command regex?

indicate that `sale = []` is for the `juice` command.
@nayakrujul
Copy link
Contributor

@PlaceReporter99 probably, but I haven't done much of this either, so I'm not too sure. @GingerIndustries can tell you though.

@gingershaped
Copy link
Contributor

I'm on vacation right now, will review when I get back.

@PlaceReporter99
Copy link
Contributor Author

@GingerIndustries I hope you have a nice vacation!

@PlaceReporter99
Copy link
Contributor Author

@nayakrujul since i made a few more commits I've re-requested review.

Copy link
Contributor

@nayakrujul nayakrujul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work @PlaceReporter99

@PlaceReporter99
Copy link
Contributor Author

@GingerIndustries can you review this?

@gingershaped
Copy link
Contributor

I have a better idea for the juice system, which I will be implementing soon(tm). Closing this for now.

@PlaceReporter99
Copy link
Contributor Author

@GingerIndustries soon => not_soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We sell juice now
3 participants