Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add READY_FOR_PICKUP UPR status and misc refactors/bugfixes #180

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Add READY_FOR_PICKUP UPR status and misc refactors/bugfixes #180

merged 3 commits into from
Jan 3, 2024

Conversation

ansonjwhe
Copy link
Collaborator

@ansonjwhe ansonjwhe commented Jan 1, 2024 •
edited
Loading

  • Changed copytext for SF emails
  • Replaced placeholder text in SF confirmation modals
  • Fixed UPR admin table PO num and Req num states not updating on ticket change
  • Fixed claim page crashing (toUpperCase in hooks.js)

victorzheng02
victorzheng02 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@victorzheng02 victorzheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, two small comments

backend/service/uwfinancepurchases.service.js Outdated Show resolved Hide resolved
frontend/src/components/TicketContent/UPRAdminContentTable.js Outdated Show resolved Hide resolved
@ansonjwhe ansonjwhe merged commit a5b573e into master Jan 3, 2024
2 checks passed
@ansonjwhe
Copy link
Collaborator Author

resolves #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorzheng02 victorzheng02 victorzheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansonjwhe @victorzheng02