Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 5 Compatibility Issue #1

Open
redbaty opened this issue Nov 8, 2017 · 1 comment
Open

Angular 5 Compatibility Issue #1

redbaty opened this issue Nov 8, 2017 · 1 comment

Comments

@redbaty
Copy link

redbaty commented Nov 8, 2017

OpaqueToken has been replaced by InjectionToken

@laukotomi
Copy link

I added the files of the repository's src folder to my project as a module, replaced OpaqueTokens by InjectionTokens (there are only 2 use of it I guess) and it works fine.

However there is still a not-so-nice circular dependency in this module, because signalr.module.ts and signalr.ts are referencing each other. I fixed this too in my forked module, but I think it should be fixed in this module too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants