-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redemption time #253
Comments
I believe this is legacy and that the ISSUER_PROTOCOL.md is out of date. The redemption_time is no longer encoded in the redemption in PSTv1. The current struct, afaik, is:
Client_data is un specified, but in chrome's implementation this is a CBOR encoded payload. |
I've added a note that ISSUER_PROTOCOL is out of date, hopefully we'll get the spec changes merged in early next week (tracking as part of #230), but Colin's struct udnerstanding is the current one. |
@dvorak42 is |
In the version we ended up on for PSTv1, we don't currently bind |
Great -- thanks. If you chop it out, are you left with basic Privacy Pass? |
Yeah, if we end up chopping it out I think we can align the redeemrequest to be the token shape from privacypass. |
Even if you left it in, couldn't you achieve what you want via Privacy Pass with public metadata? |
This would be a binding at redemption time, so we wouldn't be able to use public metadata then. |
fwiw, the current
Presumably, the origin is intended to use this to prevent replay and forgeries. |
How can it be used to prevent replay and forgeries if origin (site sending the redemption request) does not have direct access to client_data? |
Why is
redemption_time
encoded in a redemption request? Can't redeemers simply infer this time from when a request is received? It seems a bit superfluous to me.The text was updated successfully, but these errors were encountered: