-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labeling transitions to customize styling #176
Comments
I think that's a good idea.. I wonder if name should become a parameter to the ::page-transition(home-to-about) :>> page-transition-outgoing-image(root) {
...
} This also works nicely if in the future we want to support multiple independent transitions where you can just specify different names for each one |
The nice thing about using classes is you can add many of them. For example, let's say that the home page has a bigger header than other pages, and the about page doesn't have a sidebar. You could decide that In this case it'd be better to express "large-header-to-small-header" and "sidebar-exiting", which you can do with two classes, but cannot do with one name. There's also back vs forward transitions. We should think about how we'd solve this for MPA (the answer may still be classes). |
What about adding classes to the pseudoelements, instead of to the document or shared elements? It looks like you're already thinking about exposing the psuedo elements from the transition Object? |
Innnnteresting. I'll look into how that works parsing-wise |
Currently if you want to configure a transition, you can add a class to the document or the elements, but this feels a little rough.
Instead, if there as an option to label a transition, you could style it more directly.
The text was updated successfully, but these errors were encountered: