Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspace and Ctrl+Backspace flipped #31

Open
sitiom opened this issue Feb 17, 2022 · 12 comments
Open

Backspace and Ctrl+Backspace flipped #31

sitiom opened this issue Feb 17, 2022 · 12 comments

Comments

@sitiom
Copy link
Contributor

sitiom commented Feb 17, 2022

On latest commit (37da8b5). It actually also happens on the latest release by doing powersession rec test.cast -c pwsh.

asciicast

@ibigbug
Copy link
Member

ibigbug commented Feb 17, 2022

It is an issue.

have no idea how to fix - looks like Console.ReadKey doesn't get Modifier while ctrl-BS is pressed:

image

@ibigbug
Copy link
Member

ibigbug commented Jun 1, 2022

@sitiom this should be fixed in the latest Rust version, please feel free checkout the main branch

@sitiom
Copy link
Contributor Author

sitiom commented Jun 2, 2022

Thanks. This is fixed now. However, when trying to edit around Neovim for some time, I get this error:
image

This command doesn't work too:
image

So far the Rust version is not on par with the C# version. It doesn't have the features incorporated in #29. Hopefully, you can add them too.

@sitiom sitiom closed this as completed Jun 2, 2022
@sitiom sitiom reopened this Jun 2, 2022
@ibigbug
Copy link
Member

ibigbug commented Jun 2, 2022

thanks for reporting!

I just updated 0.1.3 at: #38

and nvim seems working fine: https://asciinema.org/a/499016

please feel free to try it out

@sitiom
Copy link
Contributor Author

sitiom commented Jun 2, 2022

Everything seems to be good, and Neovim is somehow working fine now. But the terminfo for Windows terminal should be ms-terminal as fixed in #32.

powersession upload without any arguments errors out:
image

Also, The OS info is not showing up on the recording. I guess the user agent doesn't match the format like in the C# version:
image

@ibigbug
Copy link
Member

ibigbug commented Jun 2, 2022

right, looks like it has a requirement different from the sample here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent#microsoft_edge_ua_string

i'll fix

@sitiom
Copy link
Contributor Author

sitiom commented Jun 2, 2022

The last thing would be to add the --version flag, which is missing currently.

@ibigbug
Copy link
Member

ibigbug commented Jun 2, 2022

0.1.4 should have all of this. one thing I don't understand is the OS is only showing Windows for me, not Windows 10 though the UA looks like this: [TRACE] ua: asciinema/2.0.0 rust/1.55.0 Windows/10-10.0.22000-SP0 you see anything?

@sitiom
Copy link
Contributor Author

sitiom commented Jun 3, 2022

It looks like it has been like that recently; even in the C# version, new uploads show up as Windows. Other than that, everything seems to have been resolved now, thanks!

@sitiom sitiom closed this as completed Jun 3, 2022
@sitiom
Copy link
Contributor Author

sitiom commented Jun 3, 2022

@ibigbug Just a question, is the C# version still maintained? I see you released both versions of them recently. I would like to update the scoop manifest accordingly. If you plan to deprecate the C# version, I suggest bumping the tag to v2.0.0 for the rust version instead of prefixing it with cs- or rs- for consistency.

@ibigbug
Copy link
Member

ibigbug commented Jun 3, 2022

Great to know, thanks!

The C# version won't be much updated. The latest release was a fix for the breaking API change from System.CommandLine nuget. However PRs are still well come if people are interested ;)

@sitiom
Copy link
Contributor Author

sitiom commented Jun 3, 2022

If the rust version has been moved to the new repo, it means the issue still exists in this version.

@sitiom sitiom reopened this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants