Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha Windows variant version numbers do not contain hashes #642

Closed
3gf8jv4dv opened this issue Nov 7, 2024 · 2 comments
Closed

Alpha Windows variant version numbers do not contain hashes #642

3gf8jv4dv opened this issue Nov 7, 2024 · 2 comments

Comments

@3gf8jv4dv
Copy link

Judging from the picture in #639, the version number output of the Linux variant contains the alpha and hash fields.

However, for Windows variants, the version number output by using -v is clash-rs 0.7.0, regardless of whether it is an Alpha build or not.

This caused Windows users to be unable to correctly identify whether the build they were using was an Alpha build. This also affected downstream Clash Nyanpasu — after updating Clash Rust Alpha in the software, since its version number was still 0.7.0, it would still prompt that a new update was available even after updating to the latest version.

@ibigbug
Copy link
Member

ibigbug commented Nov 7, 2024

actions/runner#1636 (comment)

seems windows env vars are set in a slightly different way

@ibigbug ibigbug mentioned this issue Nov 7, 2024
12 tasks
@ibigbug
Copy link
Member

ibigbug commented Nov 7, 2024

 Downloads  & '.\clash-x86_64-pc-windows-msvc(1).exe' -v
clash-rs 0.7.0-alpha+sha.e47771c

fixed in #643

@ibigbug ibigbug closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants