Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gb0101010101 experimental 1 #118

Merged

Conversation

madgrizzle
Copy link
Collaborator

No description provided.

tinker and others added 30 commits March 2, 2020 12:45
…p code. Standardize exception handling. Format code.
…ve debugging print(), remove legacy commented code, send file as attachment to retain filename with datestamp.
…mplate to restrict selection of files. Make mimetype variable optional for backwards compatibility when not provided.
…n and does not delete existing log files. Add TODO comments to fix this later.
…ardcoded pixel dimensions are not used in CSS calc(). Nav moved into body to get proper sizing for subsequent elements. Additional Divs added to make resizing work. Controller Messages box has min-height so always visible; otherwise resizes to available space. Fixed JS resizing to shrink when window made smaller.
… 'Controller Messages' heading smaller. Gives 4 more lines for controller message display on 1080P screen.
@madgrizzle madgrizzle merged commit 868cf88 into WebControlCNC:experimental Mar 24, 2020
@gb0101010101
Copy link
Contributor

Just a reminder that these changes have not been committed to Master. Others are submitting PRs based on Master that are causing merge conflicts. Really want this code incorporated as it fixed many issues and required extensive testing.

@madgrizzle
Copy link
Collaborator Author

@WebControlCNC/developers @WebControlCNC/maintainers

Can we work on prioritizing this particular PR. I put it off because I had screwed up the release process and wanted things to settle down before making this change.. it's a pretty big rework that needs to be well rested.

@emilecantin
Copy link
Contributor

I've opened #153 to track progress on that work

@gb0101010101
Copy link
Contributor

#153 was correctly closed as existing experimental branch got messed up during migration and did not contain the desired code changes. Latest PR code and discussion on this issues moved to #117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants