-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Inline text-box
, text-box-trim
, text-box-edge
#432
Comments
I'll mark this as |
Shipping this already is probably even better than just marking as support? :D https://webkit.org/blog/16301/webkit-features-in-safari-18-2/
👏 |
ISSUE 12 in the spec draft says "Do not ship (yet)."? |
Chrome is also just shipping :D |
Safari shipped |
@jensimmons @fantasai I was wondering if Safari supports |
@kojiishi I've noticed that it works differently in Chrome canary than Safari, can you investigate this before Ship? https://codepen.io/jensimmons/full/gbYMERz/d04ddec1bd31a5ce3792d3bfcb34dffb |
Please file a bug over at https://crbug.com/ so that this is tracked. Thank you. |
It should. |
This looks like a bug in Chromium fwiw.
|
Thanks for chiming in everyone, I have filed https://issues.chromium.org/issues/385160696 and CC’d @yisibl and @kojiishi on the bug. |
Please take a look at w3c/csswg-drafts#10703. It looks like the spec hasn't updated for this resolution. @fantasai In this case, it has |
@kojiishi It's possible WebKit needs to update for this resolution, but in that case, I think Chromium still has a bug with the shorthand:
|
@kojiishi I am pretty sure I updated the spec? https://www.w3.org/TR/css-inline-3/#text-edges That said, |
@argyleink Yeah, we needed to resolve some issues around fragmentation, inheritance, etc. that were still up in the air. But with @kojiishi's help we got through those issues, and I just finally updated the spec. |
I've been building demos of
I'll file an issue at the CSSWG about this, but meanwhile I do not believe browsers should implement these rules as invalid. |
I'm not sure how I feel about making the shorthand parsing different from the longhand parsing. I'd rather have those 2 be identical. I don't really have a strong opinion whether to require two values though. |
Whether to require two values or not is due to the lack of consensus at w3c/csswg-drafts#10703. Both sides have reasonable points and supporters that it wasn't easy to reach a consensus. I think we can get more feedback and stats when developers started using this feature, which can help us to reach a consensus. Until then, I think more restrictive implementation is safe, as whichever change won't break existing sites. |
I wrote up the issue today at w3c/csswg-drafts#11460 |
WebKittens
@fantasai @nt1m
Title of the proposal
CSS Inline
text-box
,text-box-trim
,text-box-edge
URL to the spec
https://drafts.csswg.org/css-inline-3/#leading-trim
URL to the spec's repository
No response
Issue Tracker URL
No response
Explainer URL
https://kojiishi.github.io/explainers/text-box-trim
TAG Design Review URL
w3ctag/design-reviews#1021
Mozilla standards-positions issue URL
mozilla/standards-positions#1105
WebKit Bugzilla URL
No response
Radar URL
No response
Description
To achieve optical balance of text content, the text-box-trim and text-box-edge properties, along with the text-box shorthand property, make finer control of vertical alignment of text possible.
The text was updated successfully, but these errors were encountered: