Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container fails to start because of existing symlink #2579

Closed
2 tasks done
raymondelooff opened this issue Aug 17, 2024 · 3 comments · Fixed by #2591
Closed
2 tasks done

Container fails to start because of existing symlink #2579

raymondelooff opened this issue Aug 17, 2024 · 3 comments · Fixed by #2591
Assignees
@nijel
Labels
bug Something is broken.

Comments

@raymondelooff
Copy link

Describe the issue

Because of changes in c5a1c3b, containers now fail to start a second time after being stopped. The start script tries to create Supervisor config file symlinks, but those ln -s commands fail when a symlink already exists (because they get created during the first start). Adding the -f flag to all the symlink commands will likely fix the issue.

weblate-1  | ln: failed to create symbolic link '/var/run/supervisor.conf.d/celery-backup.conf': File exists
weblate-1  | ln: failed to create symbolic link '/var/run/supervisor.conf.d/celery-beat.conf': File exists
weblate-1  | ln: failed to create symbolic link '/var/run/supervisor.conf.d/celery-celery.conf': File exists
weblate-1  | ln: failed to create symbolic link '/var/run/supervisor.conf.d/celery-memory.conf': File exists
weblate-1  | ln: failed to create symbolic link '/var/run/supervisor.conf.d/celery-notify.conf': File exists
weblate-1  | ln: failed to create symbolic link '/var/run/supervisor.conf.d/celery-translate.conf': File exists
weblate-1  | ln: failed to create symbolic link '/var/run/supervisor.conf.d/check.conf': File exists
weblate-1  | ln: failed to create symbolic link '/var/run/supervisor.conf.d/web.conf': File exists

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Start a new container
  2. Stop the container, don't remove it
  3. Start the container again

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

Additional context

No response
@nijel nijel added the bug Something is broken. label Aug 19, 2024
@nijel
Copy link
Member

nijel commented Aug 19, 2024

We should also add tests to cover this situation while fixing this.

@cedk cedk mentioned this issue Aug 20, 2024
Closed
nijel added a commit to nijel/docker that referenced this issue Aug 26, 2024
@nijel
feat(ci): add test for service restart
affb3a0 
This is different than fresh start as the volumes persist, see WeblateOrg#2579
@nijel nijel mentioned this issue Aug 26, 2024
Merged
5 tasks
nijel added a commit to nijel/docker that referenced this issue Aug 26, 2024
@nijel
feat(ci): add test for service restart
e633491 
This is different than fresh start as the volumes persist, see WeblateOrg#2579
@nijel
Copy link
Member

nijel commented Aug 26, 2024

This doesn't happen in the recommended setup when using tmpfs for /run, as in that case, the tmpfs doesn't survive the container restart.

nijel added a commit to nijel/docker-compose that referenced this issue Aug 26, 2024
@nijel
fix(generate): remove /run tmpfs mount when testing read-write setup
1c556f0 
This is the typical setup users will have from older time, so test that
rather than mixed setup with /run on tmpfs and /tmp not.

See WeblateOrg/docker#2579
@nijel nijel mentioned this issue Aug 26, 2024
Merged
5 tasks
nijel added a commit to nijel/docker-compose that referenced this issue Aug 26, 2024
@nijel
fix(generate): remove /run tmpfs mount when testing read-write setup
29cdeed 
This is the typical setup users will have from older time, so test that
rather than mixed setup with /run on tmpfs and /tmp not.

See WeblateOrg/docker#2579
nijel added a commit to WeblateOrg/docker-compose that referenced this issue Aug 26, 2024
@nijel
fix(generate): remove /run tmpfs mount when testing read-write setup
b23dbd9 
This is the typical setup users will have from older time, so test that
rather than mixed setup with /run on tmpfs and /tmp not.

See WeblateOrg/docker#2579
nijel added a commit to nijel/docker that referenced this issue Aug 26, 2024
@nijel
feat(ci): add test for service restart
0d5ef65 
This is different than fresh start as the volumes persist, see WeblateOrg#2579
@nijel nijel self-assigned this Aug 26, 2024
nijel added a commit to nijel/docker that referenced this issue Aug 26, 2024
@nijel
feat(ci): add test for service restart
d1e7325 
This is different than fresh start as the volumes persist, see WeblateOrg#2579
nijel added a commit to nijel/docker that referenced this issue Aug 26, 2024
@nijel
fix(start): remove stale supervisor configuration files on start
8167a7b 
Repeated start might have existing files around.

Fixes WeblateOrg#2579
@nijel nijel linked a pull request Aug 26, 2024 that will close this issue
feat(ci): add test for service restart #2591
Merged
5 tasks
nijel added a commit to nijel/docker that referenced this issue Aug 26, 2024
@nijel
fix(start): remove stale supervisor configuration files on start
74a2d46 
Repeated start might have existing files around.

Fixes WeblateOrg#2579
nijel added a commit to nijel/docker that referenced this issue Aug 26, 2024
@nijel
feat(ci): add test for service restart
415b4f5 
This is different than fresh start as the volumes persist, see WeblateOrg#2579
nijel added a commit to nijel/docker that referenced this issue Aug 26, 2024
@nijel
fix(start): remove stale supervisor configuration files on start
bf44228 
Repeated start might have existing files around.

Fixes WeblateOrg#2579
nijel added a commit that referenced this issue Aug 26, 2024
@nijel
feat(ci): add test for service restart
1979bf1 
This is different than fresh start as the volumes persist, see #2579
nijel added a commit that referenced this issue Aug 26, 2024
@nijel
fix(start): remove stale supervisor configuration files on start
df0ea4a 
Repeated start might have existing files around.

Fixes #2579
@github-actions GitHub Actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@nijel nijel mentioned this issue Aug 30, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
bug Something is broken.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ci): add test for service restart nijel/docker
2 participants
@nijel @raymondelooff