Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tut1 Team Acceptance (Last Issue to Close) #70

Closed
3 of 4 tasks
dehann opened this issue Apr 4, 2022 · 13 comments
Closed
3 of 4 tasks

Tut1 Team Acceptance (Last Issue to Close) #70

dehann opened this issue Apr 4, 2022 · 13 comments
Assignees

Comments

@dehann
Copy link
Contributor

dehann commented Apr 4, 2022

This is an acknowledgement that this epic is complete. Not just your part or what you know, but you are confident that we can move forward and call this done from every perspective.

The work is ready for showtime. It can be marketed and shown without hesitation.

@Affie
Copy link
Contributor

Affie commented Apr 4, 2022

I'll re-run tests in binder tomorrow.

@dehann dehann changed the title Team Acceptance (Last Issue to Close) Tut1 Team Acceptance (Last Issue to Close) Apr 6, 2022
@GearsAD
Copy link
Contributor

GearsAD commented Apr 6, 2022

I'm happy with tut1

@Affie
Copy link
Contributor

Affie commented Apr 6, 2022

If this is for end-to-end acceptance, there are still some issues to be closed.

If it's just the notebooks, I'm happy.

@jim-hill-r
Copy link
Contributor

If this is for end-to-end acceptance, there are still some issues to be closed.

This is for end-to-end.

@jim-hill-r
Copy link
Contributor

The card and landing page text is complete and ready for review.

Are we going to move NavAbility/NavAbilitySDK.jl#81 out of this epic? Is so, then I'll move it and do my review of the end to end.

@dehann
Copy link
Contributor Author

dehann commented Apr 7, 2022

yeah, lets move SDK.jl 81 out as that is a code quality thing more than MVP end-to-end functionality. I'd say it's above and beyond, unless there is push back.

@GearsAD
Copy link
Contributor

GearsAD commented Apr 7, 2022

Yeah it's not tied to MVP, I'm going to move it out.

@dehann
Copy link
Contributor Author

dehann commented Apr 8, 2022

I just checked the Static Rendered pages and they still have the old content. I think Jim just updated the image rendering there, so these will likely update with the nightly build?

@Affie
Copy link
Contributor

Affie commented Apr 8, 2022

Static rendering is not working on plotSLAM2D

@dehann
Copy link
Contributor Author

dehann commented Apr 11, 2022

  • All static rendering to PNG has been fixed.
  • Complete rewrite of intro with big application example lead in
  • SDK.jl v0.4.1 allows for graphics markdown badge links to Graph and Geom Viz, updated in notebook.
    • SDK.py still uses url links for viz, will update that to badges as part later tutorial work
  • I checked CJL, SDK.jl, SDK.py,
  • updated landing page, awaiting a review and merge:

I have no further MVP updates on Tut1, @Affie and @jim-hill-r please do acceptance so we can close the epic -- thanks.

@Affie Affie removed their assignment Apr 14, 2022
@GearsAD
Copy link
Contributor

GearsAD commented Apr 22, 2022

Can we close this, call it a success?

@dehann
Copy link
Contributor Author

dehann commented Apr 22, 2022

Slight scope creep that I'm going to fix today:

  • I'm going to add image outputs to all notebooks for the static renders to make sense.
  • I'll make sure [email protected] is used on all notebooks for Tut1.

Bar that, I'm planning close the Tut1 Epic tonight regardless - it's the #2 priority Roadmap Epic and has been blocked on the same single acceptance ticket for over 2 weeks now. Assuming @jim-hill-r might review at some point, and if he finds stuff we can triage those issues separately.

@dehann
Copy link
Contributor Author

dehann commented Apr 23, 2022

I just checked, SDK.jl and SDK.py on Tut1 use [email protected] as userId

@dehann dehann closed this as completed Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants