New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing & in pagination link #91

Open

cathoderaydude opened this issue Jun 13, 2020 · 1 comment

Labels

bug

Collaborator

cathoderaydude commented Jun 13, 2020

If the pagination list is long enough to produce an ellipsis, the "last page" link will be missing a & before page and will not work.

cathoderaydude added the bug label

jasonsperske commented Jul 19, 2021 •

edited

Loading

Here is how you reproduce this bug:

Search for % (example)
Click on 56

Other pages form the URLs correctly (including the & separating the query params) but the last page is missing the & separating q= from page=. The bug is caused by this line https://github.com/WinWorldPC/adventure/blob/master/adventure/views/search.ejs#L167

jasonsperske mentioned this issue

Adds missing & to last page of search results #101

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment