Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job-based configuration on DressUp does not work correctly #1919

Open
johnarnfield opened this issue Aug 10, 2020 · 0 comments
Open

Job-based configuration on DressUp does not work correctly #1919

johnarnfield opened this issue Aug 10, 2020 · 0 comments

Comments

@johnarnfield
Copy link
Contributor

johnarnfield commented Aug 10, 2020

As per the README:

Profiles named JOB or NAME_JOB will be checked for on job changes.

However I don't believe this functions at all. The job change hook uses name to load the configuration instead of name_short as I would expect it to, but even with this fix, the configuration does not load or save.

windower.register_event('job change',function(job)
    if load_profile(res.jobs[job].name) then

I would expect job based configurations to behave as overrides to the default settings, and defaults should be repplied when changing from those jobs with profiles applied back to another, but I don't believe this happens either.

Saving settings using //du save xxx only ever creates an empty xml node named xxx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant