Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MABC should configure its clustering funcs in configure() not operator(). #379

Open
brettviren opened this issue Feb 13, 2025 · 0 comments

Comments

@brettviren
Copy link
Member

This perhaps more about a general cleanup / refactoring of MABC.

But, specifically, the clustering "functions" (actually classes that usually but not always call functions) have no chance to validate their configuration until executed. Config should be done during the configuration phase. Doing it during execution means config errors do not show up until some possibly lengthy period of processing is done. Also, the configuration phase is meant to assure single-threaded context which this execution-time config violates.

There are various other "wrinkles" in MABC of this type that perhaps can best be smoothed out by lifting the clustering "functions" into actual DFP nodes.

Related #377

@brettviren brettviren added this to the Clustering ported milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant