-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-origin restriction circumvention? #47
Comments
wait how did u detect the likelihood of media being unsupported? |
It's this check
See the comment: jumpcutter/src/entry-points/content/AllMediaElementsController.ts Lines 96 to 115 in c63821f
So it's not like we detect an actual likelihood expressed as a number between 0 and 100%, but rather "it's cross-origin, so it's probably not gonna work". |
Oh i see. I had this issue in my extension too so I'll just use this option 😞 |
We can't directly analyze audio from video elements whose source is cross-origin, although they can be played back just fine. And this applies to many websites (Zoom call recordings, Invidious, Google Drive videos, many others).
Currently what we're doing is suggest opening the source directly in a new tab:
But would be cool if it just worked somehow. Preferably without violating what's cross-origin restriction is made for -
Somewhat of an option is to contact the website owners and ask them to apply the required cross-origin headers to the source (I think it's
Access-Control-Allow-Origin
?) but you can't contact them all.More info:
MediaElementAudioSourceNode
is CORS-restricted & b) revertcreateMediaElementSource
WebAudio/web-audio-api#2453HTMLMediaElement
's spec, search for "cross": https://html.spec.whatwg.org/multipage/media.html#security-and-privacy-considerationsAdvice or thoughts are appreciated (as always).
The text was updated successfully, but these errors were encountered: