Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Pages three pane view overlaps on certain screen sizes #62104

Open
ndiego opened this issue May 29, 2024 · 4 comments
Open

Site Editor: Pages three pane view overlaps on certain screen sizes #62104

ndiego opened this issue May 29, 2024 · 4 comments
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended

Comments

@ndiego
Copy link
Member

ndiego commented May 29, 2024

Description

When accessing the Pages screen in the Site Editor on smaller screens, such as tablets, two panes overlap. See the video for a walkthrough.

Step-by-step reproduction instructions

  1. Use TT4 and the latest version of Gutenberg
  2. Open the Site Editor and navigate to the Pages screen
  3. Make the browser width smaller, either manually or using the inspector (like in the video)
  4. Notice that the two panes overlap

Screenshots, screen recording, code snippet

site-editor-overlapping.mp4

Environment info

  • WordPress 6.5
  • Gutenberg 18.4.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ndiego ndiego added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels May 29, 2024
@ndiego ndiego moved this to ❓ Triage in WordPress 6.6 Editor Tasks May 29, 2024
@annezazu
Copy link
Contributor

Noting this is overall tracked here: #60847

@colorful-tones colorful-tones moved this from ❓ Triage to 📥 Todo in WordPress 6.6 Editor Tasks Jun 3, 2024
@colorful-tones colorful-tones added the Needs Dev Ready for, and needs developer efforts label Jun 3, 2024
@aatanasovdev
Copy link
Contributor

I'd like to discuss the expected result of this task. Reviewing #60847, it seems that the second and third panes will be a scrollable area, which requires changing the markup (wrapping the content and the canvas).

However, the Layout component is used by all Site Editor Data Views, which will require testing each of them. Considering that I'm not sure whether, in this task, we'll follow the new responsive approach or a temporary solution should be implemented.

@stokesman
Copy link
Contributor

stokesman commented Jun 25, 2024

it seems that the second and third panes will be a scrollable area, which requires changing the markup (wrapping the content and the canvas).

It’s not necessarily the case the markup will have to change.

Here’s a quick bit of CSS that allows for horizontal scrolling without markup changes and prevents the panes from overlapping. It can be pasted into styles in dev tools if anyone cares to experiment.

.edit-site-layout__content {
    overflow: auto;
}

.interface-navigable-region.edit-site-layout__sidebar-region {
    position: sticky;
    left: 0;
    background: #1e1e1e;
}

.edit-site-layout__content {
    padding-inline: 0 16px;
}

.edit-site-layout__area,
.edit-site-layout__canvas-container {
    min-width: 320px;
    z-index: auto;
}

@media (min-width: 782px) {
    .edit-site-layout__canvas {
        width: 100%;
    }
}

@aatanasovdev
Copy link
Contributor

@stokesman, thank you for suggesting this approach, but it will make the entire container (the tree panes) a scrollable area, and I'm not sure if this is the right direction in terms of the best possible user experience. Another opinion would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: 📥 Todo
Development

No branches or pull requests

5 participants