Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles > Typography: Custom typesets can not be selected, theme typesets can not be deselected #67064

Closed
3 of 6 tasks
carolinan opened this issue Nov 18, 2024 · 4 comments
Closed
3 of 6 tasks
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@carolinan
Copy link
Contributor

Description

When you have a block theme active, and the theme registers typography presets, the user can select between them in the Styles sidebar > Typography. By default, the first preset is selected:

Image

But if a user opens "Manage fonts" and installs a new font and saves, it is saved as a custom style.
The new font is listed in the Fonts section, and the theme typeset is no longer shown as being selected: it has no dark border:
Image

Next, if the user clicks on any theme typeset, they have no way to re-select their custom style in the interface.

  • There is no button or similar that the user can click on to select their custom typeset.
  • The theme typeset can not be deselected: I thought that clicking on a typeset twice might unset it, but no.

The only way to get back to the custom typeset is to refresh the page before saving, or, if you have already saved, use the revisions.

Step-by-step reproduction instructions

Activate Twenty Twenty-Five.
Open the Site Editor
Open the Styles sidebar
Open the Typography panel, and next to the label that says FONTS, click on the icon that has the tooltip "Manage fonts"
Install a new font.
Save.

Select a typeset under the label TYPESETS
The theme typeset is selected.

Try to get your customized typeset back.

Screenshots, screen recording, code snippet

No response

Environment info

WordPress 6.7.

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@carolinan carolinan added [Type] Bug An existing feature does not function as intended Needs Design Needs design efforts. labels Nov 18, 2024
@carolinan
Copy link
Contributor Author

carolinan commented Nov 18, 2024

Could the customisation be added as a button last on the list of typesets? And all it would do is unset the selection of the theme typeset?

@carolinan
Copy link
Contributor Author

Originally reported here:
https://wordpress.org/support/topic/manage-fonts-not-showing/

@matiasbenedetto
Copy link
Contributor

A related issue: #59574

@carolinan
Copy link
Contributor Author

Another issue I found is that after setting a preset, it can't be unset. I would expect that if I clicked the preset again, it would be unset. In the screencast, I click several times on the preset, but it is not unset.

That's exactly it, thank you @matiasbenedetto Let's close this one.

@carolinan carolinan added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed and removed [Type] Bug An existing feature does not function as intended Needs Design Needs design efforts. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

2 participants