Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ad hoc badges with Badge component #68020

Closed
3 of 4 tasks
jameskoster opened this issue Dec 16, 2024 · 3 comments · Fixed by #68566
Closed
3 of 4 tasks

Replace ad hoc badges with Badge component #68020

jameskoster opened this issue Dec 16, 2024 · 3 comments · Fixed by #68566
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Dec 16, 2024

With the new Badge component merged, ad hoc badge elements can now be replaced with the reusable component for improved consistency and sustainability.

  • Page markers (homepage, posts page) in data views
  • Page markets (homepage, posts page) in Inspector
  • 'Badge' fields in data views
  • Anchors in List View
Image Image Image Image
@jameskoster jameskoster added the [Type] Enhancement A suggestion for improvement. label Dec 16, 2024
@juanfra
Copy link
Member

juanfra commented Dec 17, 2024

I took a look at this, and it seems that the Page markers currently have different spacing compared to what’s coming from the Badge component (which appears to be based on the DataViews grid).

@jameskoster Should we stick with the existing spacing for the Page markers, or are we okay updating it to use what comes with the Badge component?

As for the anchor in the list view, it looks like we’re using a Truncate component there.

Partial PR for the badge in data views: #68062

@jameskoster
Copy link
Contributor Author

I think it's okay to use the spacing that comes with the component out of the box. It's a tiny detail that we can revisit later if needed.

As for the anchor in the list view, it looks like we’re using a Truncate component there

Good spot. Perhaps Badge will need to be updated to support a truncate property before we tackle that one.

@juanfra
Copy link
Member

juanfra commented Dec 19, 2024

I just merged the page markers. Will come back to the anchors in list view once the PR for #68091 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants