Details block: fix the fallback value for the Summary

[afercia]

Description

To my understanding, the following code is supposed to provide a fallback text for the details summary, when it is empty:

gutenberg/packages/block-library/src/details/save.js

Line 8 in 130b6e2

const summary = attributes.summary ? attributes.summary : 'Details';

Not sure that's correct:

• First of all, 'Details' is not translatable.
• More importantly, even when the summary is left empty, attributes.summary returns a RichTextData object so that the condition is always true. Actually, this condition should check the content of the RichText component used for the Summary.

Introduced in #49808

Step-by-step reproduction instructions

• Add a Details block.
• Leave the Summary empty.
• Add a paragraph in the details content and save.
• Go to the front end.
• Observe the Summary is empty.
• Expected: to show the fallback text 'Details'.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[t-hamano]

First of all, 'Details' is not translatable.

Unfortunately, we can't use the translate function in the save function, because it will be translated differently by the user and cause a block validation error.

I propose to remove the fallback text, i.e. display an empty summary tag if no summary text exists. I haven't found a better approach yet.

[t-hamano]

Update:

I propose to remove the fallback text, i.e. display an empty summary tag if no summary text exists. I haven't found a better approach yet.

Using the render_callback function and the iAPI, we should be able to inject a translatable fallback text if the summary text is empty. In any case, the untranslatable summary text should be removed from the save function.

[afercia]

Yep I had the impression the fallback text wasn't in the right place in the save function to start with.