Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Hub: Doesn't work properly on some screens in mobile view #69155

Closed
4 of 6 tasks
t-hamano opened this issue Feb 12, 2025 · 1 comment · Fixed by #69157
Closed
4 of 6 tasks

Site Hub: Doesn't work properly on some screens in mobile view #69155

t-hamano opened this issue Feb 12, 2025 · 1 comment · Fixed by #69157
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Mobile Web Viewport sizes for mobile and tablet devices [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Feb 12, 2025

Description

The site hub icon in mobile view has two functions:

  • On menus other than the Design menu, it returns to the upper menu.
  • On the Design menu, it returns to the dashboard.

Image

However, it may not work properly in the block theme and classic theme.


Block Theme

On the Design menu, the site hub is supposed to be a link to go back to the dashboard. This was working correctly in WP 6.7:

screenshot

Image

On the other hand, in Gutenberg trunk, the site hub is a button element that does nothing when clicked, and is mislabeled:

screenshot

Image

After some investigation, it appears that this issue occurred on #67199.


Classic Theme

Access the Patterns menu.

In WP 6.7, the site hub button navigates tothe Design menu. This is not what we want, since in WP 6.7, the only allowed menu in the site editor is the Patterns - it should be a link to the dashboard:

screenshot

Image

On the other hand, in Gutenberg trunk, the site hub is a link to the dashboard. This means you cannot return to the Design smenu, which has two menus: Styles and Patterns:

screenshot

Image

This may be related to the introduction of StyleBooks for the Classic theme, which means the Patterns menu is no longer the root menu.


Taking all of this into consideration, I believe that although not everything worked correctly in WP 6.7, there are some regressions in Gutenberg trunk that need to be fixed in WP 6.8.

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@t-hamano t-hamano added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended Mobile Web Viewport sizes for mobile and tablet devices labels Feb 12, 2025
@t-hamano t-hamano self-assigned this Feb 12, 2025
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 12, 2025
@afercia
Copy link
Contributor

afercia commented Feb 12, 2025

To my understanding, the SiteHubMobile was introduced in #63118 to solve #62878. It looks like it needs some refinements though.

@afercia afercia moved this to 🏗️ In Progress in WordPress 6.8 Editor Tasks Feb 12, 2025
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.8 Editor Tasks Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Mobile Web Viewport sizes for mobile and tablet devices [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Development

Successfully merging a pull request may close this issue.

2 participants