From 32aab158878cf4dd1a3a4ecc9c7f60d42cc31e39 Mon Sep 17 00:00:00 2001 From: Rinkal Pagdar <92097119+rinkalpagdar@users.noreply.github.com> Date: Fri, 25 Oct 2024 17:58:02 +0530 Subject: [PATCH 1/3] comments pagination numbers border and spacing support added --- docs/reference-guides/core-blocks.md | 2 +- .../data/data-core-annotations.md | 1 + .../data/data-core-block-directory.md | 1 + docs/reference-guides/data/data-core-commands.md | 1 + docs/reference-guides/data/data-core-nux.md | 1 + .../src/comments-pagination-numbers/block.json | 16 ++++++++++++++++ packages/core-commands/README.md | 1 + 7 files changed, 22 insertions(+), 1 deletion(-) diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md index dd49d156857249..982562f8ec1929 100644 --- a/docs/reference-guides/core-blocks.md +++ b/docs/reference-guides/core-blocks.md @@ -217,7 +217,7 @@ Displays a list of page numbers for comments pagination. ([Source](https://githu - **Name:** core/comments-pagination-numbers - **Category:** theme - **Parent:** core/comments-pagination -- **Supports:** color (background, gradients, ~~text~~), interactivity (clientNavigation), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~ +- **Supports:** color (background, gradients, ~~text~~), interactivity (clientNavigation), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~ ## Comments Previous Page diff --git a/docs/reference-guides/data/data-core-annotations.md b/docs/reference-guides/data/data-core-annotations.md index da86bf4b0dcf56..a2e64d27593ae1 100644 --- a/docs/reference-guides/data/data-core-annotations.md +++ b/docs/reference-guides/data/data-core-annotations.md @@ -12,6 +12,7 @@ This package is still experimental. “Experimental” means this is an early im Nothing to document. + ## Actions diff --git a/docs/reference-guides/data/data-core-block-directory.md b/docs/reference-guides/data/data-core-block-directory.md index c1fe96521adc32..0f8de6ffaaa5fd 100644 --- a/docs/reference-guides/data/data-core-block-directory.md +++ b/docs/reference-guides/data/data-core-block-directory.md @@ -106,6 +106,7 @@ _Returns_ - `boolean`: Whether a request is in progress for the blocks list. + ## Actions diff --git a/docs/reference-guides/data/data-core-commands.md b/docs/reference-guides/data/data-core-commands.md index 9621de9d98c957..1d4ecf3317f314 100644 --- a/docs/reference-guides/data/data-core-commands.md +++ b/docs/reference-guides/data/data-core-commands.md @@ -56,6 +56,7 @@ _Returns_ - `boolean`: Returns whether the command palette is open. + ## Actions diff --git a/docs/reference-guides/data/data-core-nux.md b/docs/reference-guides/data/data-core-nux.md index eb6a1c3b5c9a5b..9dae997d9f9330 100644 --- a/docs/reference-guides/data/data-core-nux.md +++ b/docs/reference-guides/data/data-core-nux.md @@ -44,6 +44,7 @@ _Returns_ - `boolean`: Whether or not the given tip is showing. + ## Actions diff --git a/packages/block-library/src/comments-pagination-numbers/block.json b/packages/block-library/src/comments-pagination-numbers/block.json index 9e9017af631978..7e7cddada004b0 100644 --- a/packages/block-library/src/comments-pagination-numbers/block.json +++ b/packages/block-library/src/comments-pagination-numbers/block.json @@ -31,6 +31,22 @@ "fontSize": true } }, + "spacing": { + "margin": true, + "padding": true + }, + "__experimentalBorder": { + "radius": true, + "color": true, + "width": true, + "style": true, + "__experimentalDefaultControls": { + "radius": true, + "color": true, + "width": true, + "style": true + } + }, "interactivity": { "clientNavigation": true } diff --git a/packages/core-commands/README.md b/packages/core-commands/README.md index a7f8073c1f1dec..83563900e252b9 100644 --- a/packages/core-commands/README.md +++ b/packages/core-commands/README.md @@ -20,6 +20,7 @@ _This package assumes that your code will run in an **ES2015+** environment. If Undocumented declaration. + ## Contributing to this package From 0ff0a619ea7a83daa404699048198458bba99e9e Mon Sep 17 00:00:00 2001 From: Rinkal Pagdar <92097119+rinkalpagdar@users.noreply.github.com> Date: Wed, 30 Oct 2024 11:23:16 +0530 Subject: [PATCH 2/3] build docs --- docs/reference-guides/data/data-core-annotations.md | 1 - docs/reference-guides/data/data-core-block-directory.md | 1 - docs/reference-guides/data/data-core-commands.md | 1 - docs/reference-guides/data/data-core-nux.md | 1 - packages/core-commands/README.md | 1 - 5 files changed, 5 deletions(-) diff --git a/docs/reference-guides/data/data-core-annotations.md b/docs/reference-guides/data/data-core-annotations.md index a2e64d27593ae1..da86bf4b0dcf56 100644 --- a/docs/reference-guides/data/data-core-annotations.md +++ b/docs/reference-guides/data/data-core-annotations.md @@ -12,7 +12,6 @@ This package is still experimental. “Experimental” means this is an early im Nothing to document. - ## Actions diff --git a/docs/reference-guides/data/data-core-block-directory.md b/docs/reference-guides/data/data-core-block-directory.md index 0f8de6ffaaa5fd..c1fe96521adc32 100644 --- a/docs/reference-guides/data/data-core-block-directory.md +++ b/docs/reference-guides/data/data-core-block-directory.md @@ -106,7 +106,6 @@ _Returns_ - `boolean`: Whether a request is in progress for the blocks list. - ## Actions diff --git a/docs/reference-guides/data/data-core-commands.md b/docs/reference-guides/data/data-core-commands.md index 1d4ecf3317f314..9621de9d98c957 100644 --- a/docs/reference-guides/data/data-core-commands.md +++ b/docs/reference-guides/data/data-core-commands.md @@ -56,7 +56,6 @@ _Returns_ - `boolean`: Returns whether the command palette is open. - ## Actions diff --git a/docs/reference-guides/data/data-core-nux.md b/docs/reference-guides/data/data-core-nux.md index 9dae997d9f9330..eb6a1c3b5c9a5b 100644 --- a/docs/reference-guides/data/data-core-nux.md +++ b/docs/reference-guides/data/data-core-nux.md @@ -44,7 +44,6 @@ _Returns_ - `boolean`: Whether or not the given tip is showing. - ## Actions diff --git a/packages/core-commands/README.md b/packages/core-commands/README.md index 83563900e252b9..a7f8073c1f1dec 100644 --- a/packages/core-commands/README.md +++ b/packages/core-commands/README.md @@ -20,7 +20,6 @@ _This package assumes that your code will run in an **ES2015+** environment. If Undocumented declaration. - ## Contributing to this package From 8c5f3397a393670ac8dd6688320ae666b340bae0 Mon Sep 17 00:00:00 2001 From: Rinkal Pagdar <92097119+rinkalpagdar@users.noreply.github.com> Date: Thu, 23 Jan 2025 14:28:32 +0530 Subject: [PATCH 3/3] Refreshed branch and box-sizing added --- .../block-library/src/comments-pagination-numbers/style.scss | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 packages/block-library/src/comments-pagination-numbers/style.scss diff --git a/packages/block-library/src/comments-pagination-numbers/style.scss b/packages/block-library/src/comments-pagination-numbers/style.scss new file mode 100644 index 00000000000000..f1e6ffedc62c42 --- /dev/null +++ b/packages/block-library/src/comments-pagination-numbers/style.scss @@ -0,0 +1,4 @@ +:where(.wp-block-comments-pagination-numbers) { + // This block has customizable padding, border-box makes that more predictable. + box-sizing: border-box; +} \ No newline at end of file