-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set separate 'thumbnail_url' for SMK #1450
Comments
I wonder if it makes sense to have a separate column for |
Anecdotally, I've noticed that the 512px endpoint seems to have quite fast responses: https://iip.smk.dk/iiif/jp2/KKSgb5100_34.TIF.jp2/full/!512,/0/default.jpg |
+1 to having this in the Perhaps we could have Elasticsearch look there first before serving a thumbnail link from the API! That way the image doesn't even have to be processed on the thumbnail server if a thumbnail URL already exists, we can just return the thumbnail URL in the API search response 😮 |
Problem
The SMK provider script ingests records with ~2MB images. These files are overloading our thumbnail service and result in an unacceptable 6-10s load time. If these requests to the thumbnail server time out, the frontend will default to using the full image url (so a page with many results from SMK could end up downloading ~20 2MB images).
We would like to keep the high quality image for
image_url
, but supply a separatethumbnail_url
with a smaller size.Description
This was actually originally implemented in this way in WordPress/openverse-api#506, so much of this code can simply be reintroduced. For a given record, it will generate:
Currently, thumbnails are hard-coded to None for images by the ImageStore. This was done in WordPress/openverse-api#519, because at the time the
thumbnail_url
was always redundant (since thumbnails are generated by the server). Now that we have a use case for needing separate image and thumbnail urls, we should remove this hard-coding.Additional context
This issue handles adding the data to the records in the Catalog. There will also need to be a change to the API to actually use the
thumbnail_url
in thumbnail generation. API issue: #675Implementation
The text was updated successfully, but these errors were encountered: