Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active state of global header item #666

Open
fcoveram opened this issue Oct 29, 2024 · 3 comments
Open

Active state of global header item #666

fcoveram opened this issue Oct 29, 2024 · 3 comments

Comments

@fcoveram
Copy link
Collaborator

As per this comment shared on #657, I worked on an improved version of active state's style of global header items.

Here you can see a section where all variants are placed in both desktop and mobile views. The rest of elements in the same page were updated to reflect the latest changes.

Menu popover of global header on desktop and mobile views
@fcoveram
Copy link
Collaborator Author

Note to @ryelle: It was easier for me adding the specs in Figma's dev mode, and I think it's also more clear. I hope this works for you. If not, let me know so I can move all those notes to this ticket.

@ryelle
Copy link
Contributor

ryelle commented Oct 30, 2024

Note to @ryelle: It was easier for me adding the specs in Figma's dev mode, and I think it's also more clear. I hope this works for you. If not, let me know so I can move all those notes to this ticket.

That still requires me to try to spot the difference for what changed, for example you've highlighted the focus state, but the focus state already looks like that. The height of 44px is highlighted, but items are already 44px tall. Is the only change the new left border for current menu item?

@fcoveram
Copy link
Collaborator Author

I understand. Sorry for not being clear.

Active state style

The active state just involves showing a border in both desktop and mobile views. Here are the specs:

  • Width: 1.5px
  • Height: 44px
  • Color: blueberry-1 in when theme is white, blueberry-2 when theme is dark

Menu spacings

I also applied a spacing tweak on mobile between the border and the menu item label

Menu items area

Global header menu on mobile with highlights on the spacings

The left and right paddings where menu items are (image above) changes from 10px to 5px

Menu item

Menu item on mobile with highlights on the spacings

The left and right paddings of menu item (image above) changes from 10px to 15px

Expected result

The outcome should look like this

View with spacing notes User view
Image Image

I hope the above is clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 To do
Development

No branches or pull requests

2 participants