-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Active state of global header item #666
Comments
Note to @ryelle: It was easier for me adding the specs in Figma's dev mode, and I think it's also more clear. I hope this works for you. If not, let me know so I can move all those notes to this ticket. |
That still requires me to try to spot the difference for what changed, for example you've highlighted the focus state, but the focus state already looks like that. The height of 44px is highlighted, but items are already 44px tall. Is the only change the new left border for current menu item? |
As per this comment shared on #657, I worked on an improved version of active state's style of global header items.
Here you can see a section where all variants are placed in both desktop and mobile views. The rest of elements in the same page were updated to reflect the latest changes.
The text was updated successfully, but these errors were encountered: