Fixed Issue x-www-form-urlencoded #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != nil { | ||
| // Payload decoding failed. | ||
| ctx = ctx.setError(BadRequest(err.Error())) | ||
| if r.Header["Content-Type"][0] == "application/x-www-form-urlencoded" { |
There was a problem hiding this comment.
This can be:
if r.Header.Get("Content-Type") == "application/x-www-form-urlencoded" {
|
I would really prefer to make payload decoding pluggable. That seems like the appropriate long-term solution. There would be a type PayloadDecoder interface {
Decode(*http.Request) Payload
}Then RegisterPayloadDecoder(contentType string, decoder PayloadDecoder)Then when a create/update request is received, we simply lookup the |
|
@alexandercampbell-wf @aaronkavlie-wf @stevenosborne-wf |
|
Build is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with the restful service attempting to unmarshal a x-www-form-urlencoded request like it is JSON in POST/PUT requests. This fix simply prevents umarshal from tampering with the request body and returning an error so it can be encoded further down the line using something like this.
I was considering doing the decoding using gorilla/schema to the payload in this PR like I'm doing in my program, but I don't know what the policy on external libraries is.