Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical dependency: the request of a dependency is an expression #1755

Closed
hoantran-it opened this issue Mar 1, 2024 · 7 comments · Fixed by #1758 · 4 remaining pull requests
Closed

Critical dependency: the request of a dependency is an expression #1755

hoantran-it opened this issue Mar 1, 2024 · 7 comments · Fixed by #1758 · 4 remaining pull requests
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@hoantran-it
Copy link

hoantran-it commented Mar 1, 2024 •
edited
Loading

The latest update introduces this issue

WARNING in ./node_modules/react-player/lib/players/Mux.js 136:14-64
Critical dependency: the request of a dependency is an expression

Could we disable it?
@hemantgogia09
Copy link

seeing the same thing with 2.15.0

@luwes luwes added the bug Indicates an unexpected problem or unintended behavior label Mar 1, 2024
@luwes
Copy link
Collaborator

luwes commented Mar 1, 2024

which framework / build tool are you using?

@hemantgogia09
Copy link

hemantgogia09 commented Mar 1, 2024 •
edited
Loading

This is some of the libraries that i think useful to know if you think i missed some important ones let me know

"react": "18.2.0",
"react-dom": "^18.2.0",

"eslint": "^8.56.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsx-a11y": "^6.8.0",
"eslint-plugin-react": "^7.33.2",
"webpack": "^5.89.0",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^4.15.1"

@ps250551
Copy link

ps250551 commented Mar 1, 2024

We are seeing this as well, but only in our github runner
Screenshot 2024-03-01 at 4 39 10 PM

@hoantran-it
Copy link
Author

which framework / build tool are you using?

I'm using create-react-app

luwes added a commit that referenced this issue Mar 2, 2024
@luwes
fix: dynamic Mux import
7f920f4 
fix #1755
@luwes luwes mentioned this issue Mar 2, 2024
Merged
luwes added a commit that referenced this issue Mar 2, 2024
@luwes
fix: dynamic Mux import (#1758)
ceff8c3 
fix #1755
@luwes
Copy link
Collaborator

luwes commented Mar 2, 2024

should be fixed in v2.15.1. let me know otherwise!

@hoantran-it
Copy link
Author

should be fixed in v2.15.1. let me know otherwise!

awesome, thanks @luwes 👍

@humanbot humanbot mentioned this issue May 19, 2024
Open
@s-laugh s-laugh mentioned this issue May 24, 2024
Open
@SuperSuperDev SuperSuperDev mentioned this issue May 24, 2024
Open
@MadisonEvans94 MadisonEvans94 mentioned this issue May 24, 2024
Open
@mohamed-samandi mohamed-samandi mentioned this issue May 24, 2024
Closed
@X-oss-byte X-oss-byte mentioned this issue May 25, 2024
Open
@gemo072 gemo072 mentioned this issue May 27, 2024
Open
@jeremyjohns10 jeremyjohns10 mentioned this issue May 28, 2024
Closed
@ast2019 ast2019 mentioned this issue Jun 14, 2024
Open
@Dheeraj12121 Dheeraj12121 mentioned this issue Jun 19, 2024
Open
@JamesUoM JamesUoM mentioned this issue Jun 23, 2024
Open
@alilateef06 alilateef06 mentioned this issue Jul 7, 2024
Open
@Skrishnan586 Skrishnan586 mentioned this issue Jul 22, 2024
Open
@WesleyR10 WesleyR10 mentioned this issue Aug 21, 2024
Open
@kanchansapkota27 kanchansapkota27 mentioned this issue Aug 24, 2024
Open
@nek0ill nek0ill mentioned this issue Sep 8, 2024
Open
This was referenced Sep 8, 2024
Open
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 20, 2024
Open
Open
@ASHOKECE1999 ASHOKECE1999 mentioned this issue Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dynamic Mux import cookpete/react-player
[Snyk] Upgrade react-player from 2.9.0 to 2.16.0 humanbot/graphql-apollo
[Snyk] Upgrade react-player from 2.12.0 to 2.16.0 DTS-STN/Service-Canada-Design-System
[Snyk] Upgrade react-player from 2.9.0 to 2.16.0 SuperSuperDev/NonoviumVideoBackend
[Snyk] Upgrade react-player from 2.11.2 to 2.16.0 MadisonEvans94/bluecloud-music
[Snyk] Upgrade react-player from 2.10.1 to 2.16.0 X-oss-byte/docs-1
[Snyk] Upgrade react-player from 2.13.0 to 2.16.0 gemo072/ngrok-docs
[Snyk] Upgrade react-player from 2.13.0 to 2.16.0 ast2019/Paykarjou
[Snyk] Upgrade react-player from 2.10.1 to 2.16.0 Dheeraj12121/ntple
[Snyk] Upgrade react-player from 2.10.0 to 2.16.0 UoM-Podcast/opencast-editor
4 participants
@luwes @hemantgogia09 @hoantran-it @ps250551