Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply asfDisallowIncomingTrustline blocker to OfferCreate txn #5089

Open
dangell7 opened this issue Aug 2, 2024 · 1 comment
Open

Apply asfDisallowIncomingTrustline blocker to OfferCreate txn #5089

dangell7 opened this issue Aug 2, 2024 · 1 comment
Labels

Comments

@dangell7
Copy link
Collaborator

dangell7 commented Aug 2, 2024

Issue Description

The asfDisallowIncomingTrustline flag was introduced in #4336. When introduced it was not applied to the CreateOffer transactor.

I believe it should be. The functionality should be similar to the asfRequireAuth flag.

Steps to Reproduce

  • Issuer "issues" USD token. (Distribution account establishes trustline ("USD") with Issuer and Issuer funds Distribution account)
  • Distribution account creates a sell offer.
  • Issuer sets asfDisallowIncomingTrustline flag.
  • User submits CreateOffer txn without a trustline for the USD currency.

The offers cross and the user now owns the token with a 0 LimitAmount Trustline. The user cannot make payments with the token but could sell the token with an offer.

Expected Result

I would expect that if the issuer has set the asfDisallowIncomingTrustline flag and a user tries to create an offer with CreateOffer but does not have the trustline or a LimitAmount > 0, the error response should be tecNO_LINE

Actual Result

The actual result is that the OfferCreate transaction succeeds.

Environment

Supporting Files

Let us discuss :)

@dangell7 dangell7 changed the title [Title with short description] (Version: [rippled version]) Apply asfDisallowIncomingTrustline blocker to OfferCreate Aug 2, 2024
@dangell7 dangell7 changed the title Apply asfDisallowIncomingTrustline blocker to OfferCreate Apply asfDisallowIncomingTrustline blocker to OfferCreate txn Aug 2, 2024
@mvadari mvadari added the Bug label Aug 2, 2024
@kohteinaung
Copy link

Hi will fine community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants