Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor XRPAmount and MPTAmount to use a common base class. Consider renaming to XRPNumber/MPTNumber/IOUNumber. #5155

Open
gregtatcam opened this issue Oct 10, 2024 · 0 comments
Labels
Feature Request Used to indicate requests to add new features

Comments

@gregtatcam
Copy link
Collaborator

Summary

They should be called MPTNumber and XRPNumber because they represent quantities, while STAmount represents a quantity plus an asset / issue / unit (however you want to think of it). These are more like Number, and convert directly to and from it.
All of the arithmetic is moving to Number after the switchover anyway. In due time, when we retire that amendment, effectively locking it in permanently, then I think we can remove MPTAmount and XRPAmount.

@gregtatcam gregtatcam added the Feature Request Used to indicate requests to add new features label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Used to indicate requests to add new features
Projects
None yet
Development

No branches or pull requests

2 participants
@gregtatcam and others