Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Find a more suitable name for MixedRealityPlayspace #896

Closed
FejZa opened this issue Oct 18, 2021 · 8 comments
Closed

Find a more suitable name for MixedRealityPlayspace #896

FejZa opened this issue Oct 18, 2021 · 8 comments

Comments

@FejZa
Copy link
Contributor

FejZa commented Oct 18, 2021

XRTK - Mixed Reality Toolkit Feature Request

Is your feature request related to a problem? Please describe

As discussed in Discord feedback I keep hearing is that people do not understand the "MixedRealityPlayspace". Most prominent questions are:

  • When I want to move the player, do I move the "Playspace"?
  • Do I put all of my scene content into the "Playspace"?
  • Why isn't it called "Player"?

So I wanna suggest renaming the playspace object. My suggestions for more suitable and self-speaking names are:

  • XRRig
  • XRPlayer
  • Player
  • XRCameraRig
@SimonDarksideJ
Copy link
Contributor

I vote for

  • XRTK.XRCameraRig

@FejZa
Copy link
Contributor Author

FejZa commented Oct 18, 2021

If we can drop the XRTK. prefix I am fine with it

@SimonDarksideJ
Copy link
Contributor

Ok fair enough, XRCameraRig seems fine to me

@FejZa
Copy link
Contributor Author

FejZa commented Oct 19, 2021

Long live democracy :D

@StephenHodgson
Copy link
Contributor

Also agreed with XRCameraRig

@FejZa
Copy link
Contributor Author

FejZa commented Oct 19, 2021

Looks like we got a deal

@SimonDarksideJ
Copy link
Contributor

image

@FejZa
Copy link
Contributor Author

FejZa commented Nov 22, 2021

Implemented in #898

@FejZa FejZa closed this as completed Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants