Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicktest fail because of deprecated api call #1191

Open
kalahel opened this issue Sep 19, 2024 · 12 comments
Open

Quicktest fail because of deprecated api call #1191

kalahel opened this issue Sep 19, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@kalahel
Copy link

kalahel commented Sep 19, 2024

Hello,

Starting from a fresh install and running ./run-docker.sh quicktest I have thoses error :

[...]
 => => writing image sha256:b01e605eccedf1632bb74cdc2e8e74fd5bfe35a84f884a11ef42c597d68a246b                                        0.0s
 => => naming to docker.io/xilinx/finn:v0.10.1-dirty.xrt_202220.2.14.354_22.04-amd64-xrt                                            0.0s

 1 warning found (use docker --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 144)

What's next:
    View a summary of image vulnerabilities and recommendations → docker scout quickview 
Obtaining file:///home/mathieu/Tools/finn/deps/qonnx
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [44 lines of output]
      /usr/local/lib/python3.10/dist-packages/setuptools/__init__.py:80: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
[...]

I have a lot of similar errors (deprecated api call).

After those messages, all the tests fail because they don't find qonnx, brevitas nor finn.

I tried forcing the installation by changing the dockerfile and adding :

RUN pip install qonnx
RUN pip install brevitas
RUN pip install finn-base

Now I have this test report : 7 failed, 8 passed, 19 warnings, 88 errors.

It seems that the script can't find some find API :

[...]
E   ModuleNotFoundError: No module named 'finn.transformation.qonnx'
[...]
E   ModuleNotFoundError: No module named 'finn.builder'
[...]

Did I do something wrong in my installation or is there a deprecation in the docker image ?

Thanks in advance !

@kalahel kalahel added the bug Something isn't working label Sep 19, 2024
@auphelia
Copy link
Collaborator

Hi @kalahel ,
Are you working with current main or dev?
This error looks like an older version of FINN.

@kalahel
Copy link
Author

kalahel commented Sep 19, 2024

Hi @auphelia, thanks for the response !

I followed the getting started guide so just cloned the repo with git clone https://github.com/Xilinx/finn/, so I guess I have the current main branch.

@auphelia
Copy link
Collaborator

That is unusual, can you share the exact commands you run in the command line and which env vars you have set?

@kalahel
Copy link
Author

kalahel commented Sep 25, 2024

I run ./run-docker.sh quicktest

My env variable are :

export FINN_XILINX_PATH=/home/mathieu/Tools/Xilinx
export FINN_XILINX_VERSION=2024.1

@auphelia
Copy link
Collaborator

We are recommending using Vivado/Vitis 2022.2 with FINN currently, but this is not the reason for the issue.
It might be that you are building from cache and that causes issues. So, you can try rebuilding the docker container. Can you please add --no-cache to the run-docker.sh script in the line docker build? To this line: https://github.com/Xilinx/finn/blob/main/run-docker.sh#L198
So: docker build -f docker/Dockerfile.finn --build-arg XRT_DEB_VERSION=$XRT_DEB_VERSION --tag=$FINN_DOCKER_TAG $FINN_DOCKER_BUILD_EXTRA --no-cache .
And try to run it again.

@kalahel
Copy link
Author

kalahel commented Sep 25, 2024

Unfortunately it did not change the result.
I linked the complete trace if it can help you find clues on what's happening.
completeTrace.txt

@auphelia
Copy link
Collaborator

From the error message it looks like it cannot build the dependencies:
From your completeTrace.txt: Make sure you're either building from a fully intact git repository or PyPI tarballs. Most other sources (such as GitHub's tarballs, a git checkout without the .git folder) don't contain the necessary metadata and will not work.

Try deleting the deps folder (/home/mathieu/Tools/finn2/finn/deps/) and run a clean fetch of the repos by using the fetch-repos.sh or re-run run-docker.sh.

Maybe the git repos didn't get downloaded completely.

@kalahel
Copy link
Author

kalahel commented Sep 25, 2024

I deleted deps, ran fetch-repos.sh and re-ran ./run-docker.sh quicktest, but still the same results.
Here the traces :
traceFetchRepo.txt
completeTrace2.txt

@auphelia
Copy link
Collaborator

Hi @kalahel,
Your error looks like a setup issue. Can you please clarify how exactly your setup looks like?

  • Do you have a linux machine?
  • Do you have a docker installation?
  • What are the exact steps you run in the command line?
  • E.g.
    git clone https://github.com/Xilinx/finn.git
    export FINN_XILINX_PATH=/home/mathieu/Tools/Xilinx
    export FINN_XILINX_VERSION=2024.1
    bash run-docker.sh

@kalahel
Copy link
Author

kalahel commented Sep 26, 2024

Hi @auphelia,

I'm currently using an Ubuntu 24.04.1 LTS with docker (version 27.2.1) desktop installation.
This is the commands I run from reboot :

sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
systemctl --user start docker-desktop
export FINN_XILINX_PATH=/home/mathieu/Tools/Xilinx
export FINN_XILINX_VERSION=2024.1
./run-docker.sh quicktest

Thank you for your support !

@auphelia
Copy link
Collaborator

Hi @kalahel ,
I was not able to recreate the issue you are/were experiencing. I saw that you commented on other topics in the FINN repos and was wondering if you were able to solve this by yourself. If yes, could you share your solution?

@kalahel
Copy link
Author

kalahel commented Oct 11, 2024

Hi @auphelia,

Unfortunatly I was not able to find a direct solution, but now I am using FINN in a WSL2 from Windows, I followed the direction given in this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants