Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Actionsの設定変更：'pull_request'イベントを'pull_request_target'イベントに置き換え #14

Closed
3 tasks
yuminn-k opened this issue Jan 29, 2024 · 0 comments
Closed
3 tasks

Github Actionsの設定変更：'pull_request'イベントを'pull_request_target'イベントに置き換え #14

yuminn-k opened this issue Jan 29, 2024 · 0 comments
Assignees
@yuminn-k
Labels
🐞 BugFix Something isn't working ⏰ P3 추가적인 의견 제시나 소소한 개선사항 ⚙ Setting 개발 환경 세팅
Milestone
GitHubプロジェクト設定

Comments

@yuminn-k
Copy link
Member

📝 Issueの概要

Github ActionsがフォークしたリポジトリからのPRで動作しない問題を解決するために、'pull_request'イベントを'pull_request_target'イベントに置き換えること。

📚 背景情報

背景としては、現在のGithub Actions設定では、PRが直接リポジトリ内で作成される場合のみ動作します。これは、forkしたリポジトリは元のリポジトリのsecretsにアクセスできないためです。

📋 具体的な作業内容

  1. Github Actionsの設定ファイルを修正する
  2. 'pull_request'イベントを'pull_request_target'イベントに置き換える
  3. 変更をコミットし、PRを作成する

📎 関連するIssueやドキュメント

特になし

🖼️ 参考スクリーンショットや図

特になし

🔄 Issueの進行状況

  • Github Actionsの設定ファイルを修正する
  • 'pull_request'イベントを'pull_request_target'イベントに置き換える
  • 変更をコミットし、PRを作成する
@yuminn-k yuminn-k added ⚙ Setting 개발 환경 세팅 🐞 BugFix Something isn't working ⏰ P3 추가적인 의견 제시나 소소한 개선사항 labels Jan 29, 2024
@yuminn-k yuminn-k self-assigned this Jan 29, 2024
yuminn-k added a commit to yuminn-k/project_minori-RAG-deployment-repo that referenced this issue Jan 29, 2024
@yuminn-k
🐛 fix: : Implement pull_request_target in Github Actions
a40f7e4 
Replaced 'pull_request' event with 'pull_request_target' event in Github Actions config file to enable actions to run on PRs from forked repositories. This change allows access to secrets in the workflows triggered by such PRs. Security considerations have been taken into account.

related issue: YJU-OKURA#14
@yuminn-k yuminn-k mentioned this issue Jan 29, 2024
Closed
2 tasks
yuminn-k added a commit to yuminn-k/project_minori-RAG-deployment-repo that referenced this issue Jan 29, 2024
@yuminn-k
🐛 fix: : Implement pull_request_target in Github Actions
341123b 
Replaced 'pull_request' event with 'pull_request_target' event in Github Actions config file to enable actions to run on PRs from forked repositories. This change allows access to secrets in the workflows triggered by such PRs. Security considerations have been taken into account.

related issue: YJU-OKURA#14
@yuminn-k yuminn-k mentioned this issue Jan 29, 2024
Merged
2 tasks
yuminn-k added a commit to yuminn-k/project_minori-RAG-deployment-repo that referenced this issue Jan 29, 2024
@yuminn-k
♻️ refactor: Move auto_reviewer.yml from .github/workflows to .github
2dc511f 
`auto_reviewer.yml` file was moved from the `.github/workflows` directory to the `.github` directory. This change is to reflect the new structure of the project.

related issue: YJU-OKURA#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuminn-k yuminn-k

Labels
🐞 BugFix Something isn't working ⏰ P3 추가적인 의견 제시나 소소한 개선사항 ⚙ Setting 개발 환경 세팅
Projects
ミノリ
Status: Done
Milestone
GitHubプロジェクト設定
Development

No branches or pull requests
1 participant
@yuminn-k