Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ROS Answers link back once the archive is online #342

Closed
jimmy-mcelwain opened this issue Dec 12, 2024 · 4 comments
Closed

Add ROS Answers link back once the archive is online #342

jimmy-mcelwain opened this issue Dec 12, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers todo Not an issue, just a TODO

Comments

@jimmy-mcelwain
Copy link
Collaborator

ROS Answers is offline, but we previously had a link with valuable discussion there. An archive of ROS Answers will be available in the future. Once it is available, simply add the new link to the README again.

Old link was here

Please create an issue to track putting this link back once the ROS Answers archive is online. The MoveIt issue does not capture the full discussion.

Originally posted by @gavanderhoorn in #337 (comment)
@gavanderhoorn gavanderhoorn added documentation Improvements or additions to documentation good first issue Good for newcomers todo Not an issue, just a TODO labels Dec 13, 2024
@jimmy-mcelwain
Copy link
Collaborator Author

The archive is seemingly online already. We haven't actually merged #337, so we can just add the link back before we merge.

@gavanderhoorn gavanderhoorn mentioned this issue Jan 7, 2025
Merged
@ted-miller ted-miller reopened this Jan 7, 2025
@ted-miller
Copy link
Collaborator

The PR hasn't been merged yet. I'll link this issue to that PR so that this closes automatically.

@ted-miller ted-miller linked a pull request Jan 7, 2025 that will close this issue
Jazzy Jalisco #337
Merged
@jimmy-mcelwain
Copy link
Collaborator Author

The PR hasn't been merged yet. I'll link this issue to that PR so that this closes automatically.

True but the removal of the link was never actually merged into main, it was only ever on the jazzy branch. This issue was created sort of prematurely, I guess since I assumed that the ROS Answers link would be dead for a long time.

@ted-miller
Copy link
Collaborator

Oh. I understand now.

@ted-miller ted-miller removed a link to a pull request Jan 7, 2025
Jazzy Jalisco #337
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers todo Not an issue, just a TODO
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gavanderhoorn @ted-miller @jimmy-mcelwain