Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Python3.11 and pre-commit #788

Open
1 task
puranss opened this issue Jan 29, 2024 · 4 comments
Open
1 task

Problem with Python3.11 and pre-commit #788

puranss opened this issue Jan 29, 2024 · 4 comments
Labels
needs more info The issue has been reviewed, but the information provided by the reporter is incomplete.

Comments

@puranss
Copy link

puranss commented Jan 29, 2024

  • I'm submitting a ...
    • [ x] bug report
    • feature request

Currently I have installed pre-commit with pip . If I do an audit it works fine with:
Nothing to audit!
I added a preconfig configuration like this

And it exits always with error code 1 (there is no secret). I tried switching different versions but nothing seems to be working

  • What is the expected behavior?

  • That it works with precommit

  • What is the motivation / use case for changing the behavior?
    *That it works with pre-commit so that I can add it to my workflow

  • Please tell us about your environment:

    • detect-secrets Version: 1.0.1
    • Python Version: 3.11
    • OS Version: macOs
    • File type (if applicable):
@gpflaum
Copy link
Contributor

gpflaum commented Jan 29, 2024

@puranss Do you have it working with another version of Python? The title implies the problem is new with Python 11.

@puranss
Copy link
Author

puranss commented Jan 30, 2024

Actually no, I edited the title. The problem is, it is working when I use audit but in precommit it fails with exit code 1 but no explaination of it.

@puranss
Copy link
Author

puranss commented Jan 30, 2024

I tried it with 3.9, there I have the same problem

@lorenzodb1
Copy link
Contributor

Hi @puranss, we just recently released support for Python 3.11. Could you please upgrade detect-secrets to v1.5 and let us know if this issue is still relevant?

@lorenzodb1 lorenzodb1 added the needs more info The issue has been reviewed, but the information provided by the reporter is incomplete. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info The issue has been reviewed, but the information provided by the reporter is incomplete.
Projects
None yet
Development

No branches or pull requests

3 participants