Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata marker #297

Open
wants to merge 2,034 commits into
base: master
Choose a base branch
from
Open

Metadata marker #297

wants to merge 2,034 commits into from

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented Apr 10, 2015

fix saving markers from metadata

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in is it tested?
    Check for code coverage. To run code coverage on only the file you changed,
    for example flotilla/compute/splicing.py, use this command:
    py.test --cov flotilla/compute/splicing.py --cov-report term-missing flotilla/test/compute/test_splicing.py
    which will show you which lines aren't covered by the tests.
  • Do the new functions have descriptive
    numpydoc
    style docstrings?
  • If it adds a new feature, is it documented as an IPython Notebook in
    examples/, and is that notebook added to doc/tutorial.rst?
  • If it adds a new plot, is it documented in the gallery, as a .py file
    in examples/?
  • Is it well formatted? Look at make pep8 and make lint output
  • Is it documented in the doc/releases/?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

olgabot and others added 30 commits January 13, 2015 17:37
* bayesian_modalities: (78 commits)
  Add flag to py.test to show top 20 tests with the longest durations
  fix test_logsumexp test
  add uniform at _logsumexp step
  change example for plot_event_modality_estimation
  make font size smaller, add renamed to fig text
  Add plot example for plot_event_modality_estimation
  turn on grid for ax_bayesfactor
  add phantom text for xlabel
  add xlabel to loglik for padding, change xticks of violin, smaller font for figtext
  add event ID using figtext which won't resize the axes
  Add renamed event id to event estimation plot
  move xlabel to loglik, fix formatting
  dropna for seaborn violinplot
  fix logsumexps
  fix reference to modality_colors
  add modality_colors to argument
  add plot_modalities_lavalamps to gallery
  fix call to modality_visualizer.event_estimation
  add plot_event_modality_estimation to show logliks and bayes factors for a modality
  Add feature_ids to plot_modalities_lavalamps, and docstring
  ...
* 'master' of github.com:YeoLab/flotilla:
  Add comment about readme badge in doc/releases/v0.2.5.txt
  Fix build badge for Travis-CI
  added feature standardization to cluster plot by default
  added feature standardization to cluster plot by default
  remove references to local server
  changed to s3 destination for metadata
  fixed feature_renamer for strings
…cingData._subset_and_standardize so it's accessible to all functions which require standardized data
…-line summary, then a longer summary beneath. And change language of boolean from "whether or not" to "If True, .."
olgabot added 24 commits March 18, 2015 11:58
* decomposition_heatmap_pcs: (31 commits)
  Add release notes
  pep8 fixes
  Add a feature renamer if there wasn't one
  Actually test if things were plotted to the axes
  add release notes
  pep8+docstrings
  Add docstring for plot
  Fix pep8, add docstring
  Add release notes
  Despine only the scatter and line plots, not the the heatmap
  add colorbar label
  shrink yticklabels down to 11 pt font
  shrink yticklabels of PC heatmap down to 12 (from 13)
  revert back to when figure was "good enough"
  Add another column to gridspec, remove ax_empty
  increase wspace, hspace, actually get yticklabels
  make yticklabels of heatmap smaller
  change wspace and hspace to 0
  make explained variance ratio graph shorter
  fix ax pcs colorbar
  ...
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) to 53.73% when pulling 947ed16 on metadata_marker into dfec06b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) to 53.73% when pulling 947ed16 on metadata_marker into dfec06b on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants