Dark mode attempt (with screenshot previews) #215
Comments
|
On Mon, 06 Jan 2025 12:02:30 -0800 Tillman Jex ***@***.***> wrote:
I've had a go at a calmer dark mode than the 'demo' theme that's bundled.
I'm willing to make a PR to integrate this into the codebase if it's deemed worthy enough.
Let me know your thoughts!
(The gray border around all the windows is my window manager. Just to clar up any confusion there)
Thanks for all your work on Yoshimi everyone. I'm an OSX convert and trying to navigate the world of music production on Linux. Very happy to have found this hidden gem.
Thanks a lot for these images. The theme looks very nice. However, from the Bank
Window (nice to see it's one of mine) it looks as if you're running a slightly
older version of Yoshimi. We since made some extensions that changes a few of
the colours. This was completed with build number 2352 (the current master is
bn 2374) so I'd suggest you rebuild with one of the recent versions, and check.
I'd then be happy to see a pull request.
…--
Will J Godfrey.
|
|
Ok, great. All is looking fine. How best to apply this change? Ideally the theme would be selectedable directly in the theme picker. I've seen how that there are some other example themes in the docs folder, which could also be imported. I as a user didn't know these existed! I think there should be a less intense dark theme selectable with the shipped synth. So users don't need to go digging for themes to save their eyes from light mode. Mine ships with "classic" and "demo" themes. But I can only see in |
|
On Sun, 12 Jan 2025 08:53:22 -0800 Tillman Jex ***@***.***> wrote:
Ok, great. All is looking fine.
OK, then I'd accept a pull request when you're ready. We like to acknowledge
contributions in the 'Yoshimi helpers' file, so what name would you like us to
use?
How best to apply this change? Ideally the theme would be selectedable directly in the theme picker. I've seen how that there are some other example themes in the docs folder, which could also be imported.
I as a user didn't know these existed! I think there should be a less intense dark theme selectable with the shipped synth. So users don't need to go digging for themes to save their eyes from light mode.
Mine ships with "classic" and "demo" themes. But I can only see in `Themes.h` that the classic theme is defined.
The problem we have is that the various distros don't like including lots of
files they don't consider essential - understandable really! We can sometimes
sneak them in as part of the code, but don't like to overdo it.
Usually, this stuff ends up in /usr/doc/examples or /usr/local/doc/examples but
there's always one that has to be different!
…--
Will J Godfrey {apparently now an 'elderly'}
|
|
Sure thing, for credit: Tillman Jex. But I can add that in the PR, no worries 👍 I'll add the theme to doc/examples/themes. |
I've had a go at a calmer dark mode than the 'demo' theme that's bundled.
I'm willing to make a PR to integrate this into the codebase if it's deemed worthy enough.
Let me know your thoughts!
(The gray border around all the windows is my window manager. Just to clar up any confusion there)
Thanks for all your work on Yoshimi everyone. I'm an OSX convert and trying to navigate the world of music production on Linux. Very happy to have found this hidden gem.
The text was updated successfully, but these errors were encountered: