Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make DehackedPickup.DetermineType() public #2964

Open
ToxicFrog opened this issue Feb 26, 2025 · 0 comments
Open

[Feature] Make DehackedPickup.DetermineType() public #2964

ToxicFrog opened this issue Feb 26, 2025 · 0 comments

Comments

@ToxicFrog
Copy link

ToxicFrog commented Feb 26, 2025

GZDoom version

4.13.2

Which game are you running with GZDoom?

Doom 2

What Operating System are you using?

Linux x86_64

If Other OS, please describe

No response

Relevant hardware info

No response

Is your feature request related to a problem? Please describe.

In zscript, it is often convenient to be able to answer questions like "what weapons are there in this level, and how many of each?" Unfortunately, in WADs like Eviternity or Going Down Turbo that include DEHACKED patches, the weapons are replaced with DehackedPickupN actors which are not part of the normal Inventory heirarchy.

DehackedPickups are aware of what their "real" type is, and can access it via DetermineType(), but this is marked private, so it's not usable by external code to query what the backing type of the DehackedPickup is.

Querying the RealPickup field doesn't work either, because it's only populated in TryPickup().

Describe the solution you'd like

The private qualifier should be removed from DehackedPickup.DetermineType() so that pk3 zscript code can call it to find out what DEHACKED items "really are".

Describe alternatives you've considered

No response

Add any other context or screenshots about the feature request here.

No response

@ToxicFrog ToxicFrog changed the title [Feature] Make DehackedItem.DetermineType() public [Feature] Make DehackedPickup.DetermineType() public Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant