Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate keygen and signing tests to be non-generic (ciphersuite-specific) #406

Open
conradoplg opened this issue Jun 21, 2023 · 0 comments

Comments

@conradoplg
Copy link
Contributor

We have generic tests in frost-core which are called by the ciphersuite crates, parametrized with their ciphersuite types.

However that does not test if the ciphersuites re-expose all the required types correctly.

We can instead have ciphersuite-specific tests which are replicated to all ciphersuites with gencode. It should be easy by simply taking the generic tests and "de-parametrizing" them. See #401 for an example.

As an upside that will greatly increase our test coverage too and will end up closing #233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant